Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Discover] Add New Mappings for S3 Type #9430

Merged
merged 3 commits into from
Feb 28, 2025
Merged

[Discover] Add New Mappings for S3 Type #9430

merged 3 commits into from
Feb 28, 2025

Conversation

sejli
Copy link
Member

@sejli sejli commented Feb 20, 2025 •
edited
Loading

Description

For PPL in OpenSearch / OpenSearch Spark, the typings for byte, short, int, integer, long, float, double, tinyint, smallint, and bigint need to be mapped to numeric. This PR adds the numeric mapping for tinyint, smallint, and bigint in the S3 dataset type.

Issues Resolved

Screenshot

Testing the changes

Changelog

  • fix: Add mappings for tinyint, smallint, and bigint in S3 dataset type

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@sejli
add new mappings for s3 type
1161477 
Signed-off-by: Sean Li <lnse@amazon.com>
@github-actions github-actions bot added all-star-contributor Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry labels Feb 20, 2025
@codecov Codecov
Copy link

codecov bot commented Feb 20, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.74%. Comparing base (601d367) to head (7e5b0b1).
Report is 13 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #9430   +/-   ##
=======================================
  Coverage   61.74%   61.74%           
=======================================
  Files        3817     3817           
  Lines       91900    91900           
  Branches    14563    14563           
=======================================
+ Hits        56741    56743    +2     
+ Misses      31498    31497    -1     
+ Partials     3661     3660    -1
Flag Coverage Δ
Linux_1 28.99% <ø> (ø)
Linux_2 56.41% <ø> (ø)
Linux_3 39.26% <ø> (+<0.01%) ⬆️
Linux_4 28.88% <ø> (ø)
Windows_1 29.00% <ø> (ø)
Windows_2 56.37% <ø> (ø)
Windows_3 39.26% <ø> (ø)
Windows_4 28.88% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

kavilla
kavilla previously approved these changes Feb 20, 2025
View reviewed changes
@sejli
super nitpick
8886653 
Signed-off-by: Sean Li <lnse@amazon.com>
@sejli sejli requested a review from angle943 as a code owner February 20, 2025 20:38
@penghuo penghuo mentioned this pull request Feb 20, 2025
Open
@github-actions github-actions bot removed the Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry label Feb 21, 2025
@abbyhu2000 abbyhu2000 merged commit 2e0c36d into opensearch-project:main Feb 28, 2025
73 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kavilla kavilla kavilla approved these changes

@abbyhu2000 abbyhu2000 abbyhu2000 approved these changes

@d-buckner d-buckner d-buckner approved these changes

@Maosaic Maosaic Maosaic approved these changes

@ananzh ananzh Awaiting requested review from ananzh ananzh is a code owner

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs is a code owner

@ZilongX ZilongX Awaiting requested review from ZilongX ZilongX is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub is a code owner

@curq curq Awaiting requested review from curq curq is a code owner

@bandinib-amzn bandinib-amzn Awaiting requested review from bandinib-amzn bandinib-amzn is a code owner

@SuZhou-Joe SuZhou-Joe Awaiting requested review from SuZhou-Joe SuZhou-Joe is a code owner

@ruanyl ruanyl Awaiting requested review from ruanyl ruanyl is a code owner

@BionIT BionIT Awaiting requested review from BionIT BionIT is a code owner

@xinruiba xinruiba Awaiting requested review from xinruiba xinruiba is a code owner

@zhyuanqi zhyuanqi Awaiting requested review from zhyuanqi zhyuanqi is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@LDrago27 LDrago27 Awaiting requested review from LDrago27 LDrago27 is a code owner

@virajsanghvi virajsanghvi Awaiting requested review from virajsanghvi virajsanghvi is a code owner

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 is a code owner

@huyaboo huyaboo Awaiting requested review from huyaboo huyaboo is a code owner

@angle943 angle943 Awaiting requested review from angle943 angle943 is a code owner

Assignees
No one assigned
Labels
all-star-contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sejli @kavilla @abbyhu2000 @d-buckner @Maosaic